Issue Details (XML | Word | Printable)

Key: SPR-1642
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Juergen Hoeller
Reporter: Carlos Sanchez
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Spring Framework

toplink tests don't compile against official oracle toplink 10.1.3

Created: 26/Jan/06 07:59 PM   Updated: 10/Aug/06 03:57 AM   Resolved: 10/Aug/06 03:57 AM
Component/s: None
Affects Version/s: 2.0 M1
Fix Version/s: 2.0 RC3

Time Tracking:
Not Specified

File Attachments: 1. Text File SPR-1642.patch (1 kB)



 Description  « Hide

I tried to compile them against toplink from http://www.oracle.com/technology/software/htdocs/eaplic.html?http://download.oracle.com/otn/java/oc4j/1013/preview/toplink_1013dp4.zip
and it doesn't work

c:\dev\m2book\code\migrating\spring\m2\spring-toplink\..\..\test\org\springframework\orm\toplink\SessionBrokerFactoryTests.java:[64,24] cannot find symbol
symbol : constructor SessionBroker(oracle.toplink.sessions.Project)
location: class oracle.toplink.sessionbroker.SessionBroker

c:\dev\m2book\code\migrating\spring\m2\spring-toplink\..\..\test\org\springframework\orm\toplink\SessionBrokerFactoryTests.java:[78,24] cannot find symbol
symbol : constructor SessionBroker(oracle.toplink.sessions.Project)
location: class oracle.toplink.sessionbroker.SessionBroker

c:\dev\m2book\code\migrating\spring\m2\spring-toplink\..\..\test\org\springframework\orm\toplink\SessionBrokerFactoryTests.java:[91,24] cannot find symbol
symbol : constructor SessionBroker(oracle.toplink.sessions.Project)
location: class oracle.toplink.sessionbroker.SessionBroker

c:\dev\m2book\code\migrating\spring\m2\spring-toplink\..\..\test\org\springframework\orm\toplink\SessionBrokerFactoryTests.java:[95,31] cannot find symbol
symbol : constructor UnitOfWork()
location: class oracle.toplink.publicinterface.UnitOfWork



Carlos Sanchez added a comment - 26/Jan/06 08:01 PM

Patch that fixes the problem


Juergen Hoeller added a comment - 27/Jan/06 05:09 PM

I wouldn't qualify this as bug, since it only affects the test suite - not the actual TopLink support code -, and there only the mock SessionBroker implementations.

I'll ask Jim (from the Oracle TopLink team) whether he can update our TopLink API jar accordingly, but it's really rather cosmetic. Well, it would be nice to be able against the official full TopLink distribution, but on the other hand, I'm just not too bothered as long as it's just the test suite that's affected.

Juergen


Carlos Sanchez added a comment - 31/Jan/06 01:01 PM

I agree that it's not very important, that's why the "minor" priority, and I don't need it at all, but I though you'd like to know. Also it's a bit dangerous testing against a jar file that it's a subset of the original and worse that it's not even api compatible. In fact if you apply this patch to make it compile against the official one, it stops compiling against the toplink-api provided with spring.


Juergen Hoeller added a comment - 10/Aug/06 03:57 AM

Fixed through a toplink-api.jar update from Oracle's Jim Clark.

Juergen