Issue Details (XML | Word | Printable)

Key: SEC-572
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Ben Alex
Reporter: Niklas Therning
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Spring Security

Cannot set ACL's parent to null

Created: 11/Oct/07 09:35 AM   Updated: 14/Apr/08 01:41 AM
Component/s: ACLs
Affects Version/s: 1.0.5
Fix Version/s: 2.0.0

Time Tracking:
Not Specified

Issue Links:
Depends
 
Duplicate
 


 Description  « Hide
The setParent() method in AclImpl throws an exception if I try to set the parent to null. I cannot see why I shouldn't be able to do this. After all, the constructor allows me to set parent to null.

In our app we have a tree like structure of objects which are secured using Acegi's ACL package (the new implementation). Permissions are inherited throughout the tree. Nodes in the tree can be moved around and can become top level nodes. This is why we would like to be able to set parent to null. The work around is to use an invisible super root node for all top level nodes. We would prefer not to have to do that.

 All   Comments   Work Log   Change History   FishEye   Builds      Sort Order: Ascending order - Click to sort in descending order
Niklas Therning added a comment - 11/Oct/07 09:56 AM
I guess I should have said that we have a forest like structure. ;-) I.e. potentially multiple trees. Nodes can be moved between trees and can become root nodes in a tree.

Ben Alex added a comment - 05/Apr/08 03:16 AM
Verified JdbcMutableAclService.updateObjectIdentity(MutableAcl) supports modifying the parent. So this should work without any significant changes.

Accordingly, AclImpl.setParent(Acl) changed to allow null parents.

SVN committed revision 2867.