Issue Details (XML | Word | Printable)

Key: BATCH-773
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Thomas Risberg
Reporter: Dave Syer
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Spring Batch

Refactor and extend ExportedJobLauncher to JobOperator

Created: 07/Aug/08 10:19 AM   Updated: 07/Oct/08 07:39 AM
Component/s: Core
Affects Version/s: 2.0.0.M1
Fix Version/s: 2.0.0.M2

Time Tracking:
Issue & Sub-Tasks
Issue Only
Original Estimate: 1.12d
Original Estimate - 1.12d
Remaining Estimate: 0.12d
Time Spent - 2.12d Remaining Estimate - 0.12d
Time Spent: 2.12d
Time Spent - 2.12d Remaining Estimate - 0.12d

File Attachments: 1. Zip Archive mylyn-context.zip (128 kB)

Issue Links:
Depends

Sub-Tasks  All   Open   

 All   Comments   Work Log   Change History   FishEye   Builds      Sort Order: Ascending order - Click to sort in descending order
Dave Syer added a comment - 18/Aug/08 02:43 AM
N.B. had to use long (not Long) in interface params (http://bugs.sun.com/view_bug.do?bug_id=6704904) so that JConsole can invoke those methods.

Dave Syer added a comment - 18/Aug/08 03:41 AM
All finished except the stop() method which needs BATCH-453 to be fixed first.

Lucas Ward added a comment - 18/Aug/08 08:44 PM
Dave,

I looked through the code for this today in detail. For the most part, the methods look fine, and I think any major methods we miss can be added, or existing ones tweaked over the next few months. The one thing that seems missing is pulling back the step execution information with it. Isn't having a running JobExecution useless without it's StepExecution (that's actually running?) I would expect when using the interface that a JobExecution that is listed as running would have all the StepExecutions with it, or at least some way to get the information separately.

I keep going back and forth on the interfaces and implementations, in some ways I like it, in others I don't, but in thinking on it again, I might be okay with it, etc. I think I just need to build an actual client against these interfaces to see how it stacks up. (I suppose you're already doing some of the same via JConsole)

I can take a crack at BATCH-453 tomorrow as well.

Dave Syer added a comment - 19/Aug/08 02:19 AM
Step execution info is provided by Map<Long, String> getStepExecutionSummaries(long executionId). You see from that all the step executions associated with a job execution (more than one might be running). Isn't that what you need? I can't test the whole thing in JConsole yet because of BATCH-453 (but it's assigned to Thomas and I am happy to wait for him, so don't start on that unless you really want to).

Dave Syer added a comment - 07/Oct/08 07:28 AM
Assigned for review. N.B. there is an issue outstanding issue (BATCH-834) to add a new related feature.