|
[
Permlink
| « Hide
]
Dave Syer added a comment - 18/Aug/08 02:43 AM
N.B. had to use long (not Long) in interface params (http://bugs.sun.com/view_bug.do?bug_id=6704904) so that JConsole can invoke those methods.
Dave,
I looked through the code for this today in detail. For the most part, the methods look fine, and I think any major methods we miss can be added, or existing ones tweaked over the next few months. The one thing that seems missing is pulling back the step execution information with it. Isn't having a running JobExecution useless without it's StepExecution (that's actually running?) I would expect when using the interface that a JobExecution that is listed as running would have all the StepExecutions with it, or at least some way to get the information separately. I keep going back and forth on the interfaces and implementations, in some ways I like it, in others I don't, but in thinking on it again, I might be okay with it, etc. I think I just need to build an actual client against these interfaces to see how it stacks up. (I suppose you're already doing some of the same via JConsole) I can take a crack at Step execution info is provided by Map<Long, String> getStepExecutionSummaries(long executionId). You see from that all the step executions associated with a job execution (more than one might be running). Isn't that what you need? I can't test the whole thing in JConsole yet because of
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||