[#BATCH-693] Refactor samples along domain contours

Spring Batch

Refactor samples along domain contours

Created: 27/Jun/08 11:19 AM Updated: 23/Sep/08 07:24 PM

Component/s:

Samples

Affects Version/s:

1.1.0

Fix Version/s:

2.0.0.M1

Time Tracking:

Original Estimate:

Remaining Estimate:

0.06d

Time Spent:

0.94d

Description

« Hide

It has always bugged me that the samples have technical packaging. It is really hard to isolate the individual domains (e.g. football).

All

Comments

Work Log

Change History

FishEye

Related Builds

Sort Order:

[ Permlink | « Hide ]

Wayne Lund added a comment - 28/Jun/08 11:38 AM

I have had the same concern. I liked the way you isolated football for the S2AP demo of spring batch. I did something similar for the project that I've recently sent to a partner were working with. I agree that samples should be separate projects so that their dependencies can be isolated to the concerns of a particular demo like the Quartz launcher.

[ Permlink | « Hide ]

Robert Kasanicky added a comment - 25/Jul/08 08:35 AM

samples now have new package structure - Dave, please take a look whether you are happy with it and the issue can be closed.

[ Permlink | « Hide ]

Dave Syer added a comment - 25/Jul/08 08:49 AM

Looks much better. How about pushing the implementations into internal packages? E.g. trade.internal contains everything except the domain objects and their Dao/service interfaces. Technical subpackages under that level would be acceptable (e.g. file, jdbc, hibernate).

[ Permlink | « Hide ]

Robert Kasanicky added a comment - 25/Jul/08 10:23 AM

I've separated the internal subpackages as suggested (didn't create further subpackages as there aren't too many classes).

[ Permlink | « Hide ]

Dave Syer added a comment - 25/Jul/08 10:34 AM

I think that looks much better.