|
If you were logged in you would be able to see more operations.
|
|
|
Spring Batch
Created: 27/Mar/08 08:27 AM
Updated: 30/Jul/08 04:41 AM
|
|
| Component/s: |
Core
|
| Affects Version/s: |
1.0.0
|
| Fix Version/s: |
2.0.0.M1
|
|
Time Tracking:
Issue & Sub-Tasks
Issue Only
Issue & Sub-Tasks
Issue Only
|
|
Original Estimate:
|
1.5d
|
|
|
Remaining Estimate:
|
0.5d
|
|
|
Time Spent:
|
1.62d
|
|
|
Original Estimate:
|
1d
|
|
|
Remaining Estimate:
|
0d
|
|
|
Time Spent:
|
1.62d
|
|
|
|
|
Issue Links:
|
Depends
|
|
|
|
This issue is depended on by:
|
|
BATCH-668
JobRepository needs to distinguish between save and update of execution context
|
|
|
|
|
|
|
|
Repository defaults to using saveOrUpdate methods, which unnecessarily blurs distinction between save and update.
1) saveOrUpdate(JobExecution) can be simply update(JobExecution), creation (and save) is handled by createJobExecution(..)
2) saveOrUpdate(StepExecution) - saved before processing records, updated in the processing loop => easy to split + shouldn't repository have createStepExecution(JobInstance, Step) similar to createJobExecution(Job, JobParameters) to be consistent?
3) saveOrUpdateExecutionContext(StepExecution) - same as 2)
|
|
Description
|
Repository defaults to using saveOrUpdate methods, which unnecessarily blurs distinction between save and update.
1) saveOrUpdate(JobExecution) can be simply update(JobExecution), creation (and save) is handled by createJobExecution(..)
2) saveOrUpdate(StepExecution) - saved before processing records, updated in the processing loop => easy to split + shouldn't repository have createStepExecution(JobInstance, Step) similar to createJobExecution(Job, JobParameters) to be consistent?
3) saveOrUpdateExecutionContext(StepExecution) - same as 2) |
Show » |
|
Improvement
Major
clean up the *Or* repository methods
