Lucas Ward - 11/Mar/08 02:36 PM Dave, i just did a quick look through on the repeat section and it all looks pretty good. The only area I felt could be expounded upon more is the ExitStatus. You mention two 'pre-built' ones, ExitStatus.FINISHED and ExitStatus.CONTINUABLE. However, it doesn't really cover the three total options for ExitStatus: boolean continuable, exit code, and exit description. I suppose the only really important one in that list, as far as the RepeatTemplate is concerned, is the continuable boolean. Perhaps you could briefly mention that the template really only looks at ExitStatus#isContinuable(), and we could have another section that covers exit code more in depth somewhere else? I kind of feel like the whole of ExitStatus should be covered somewhere though, and it seems like the Repeat chapter makes the most sense.

Dave Syer - 11/Mar/08 04:47 PM Added a sub section.

Lucas Ward - 12/Mar/08 12:24 AM I looked at the additional section, and it looks really good. However, I think it might be good to 'promote' the section up one level to be on the same general plane as the RepeatTemplate. I bring this up because I will be referencing the ExitStatus section a lot from other points in the docs, so it should probably be higher up. I still think it belongs in the Repeat chapter, just not necessarily as a sub section to RepeatTemplate.