Wayne Lund - 14/Mar/08 09:21 AM I reviewed the retry section last night and had a few general comments and questions. 1. It seems that the sections might have more code examples. I personally would like to see and example similar to what's documented in the overview of RetryTemplate with each of the sections (e.g. RetryContext, Stateless and Statefull Retry Policiesm Backoff Polciies, etc. For example, Backoff Policy shows the interface and discusses how it might be implemented but it would be nice to show a junit code snippet of one of our implementations. 2. 2.2.1 Item Processing and stateful retry was very hard reading. I'm not sure if its just me being slow but I re-read the paragaph a couple of times trying to wrap my head around what we were saying. The second paragraph overuses recognizes and is odd reading. "The way the failed operations are recognised in this implementation is by recognising the object that is returned from the ItemReader. To recognise the item the user" Maybe, "The way the failed operations are recognized in this implementation is by identifying?, filtering?, retrieving? etc. 3. I was wondering if the association of the Retry Policy didn't sound backwards in the 1st paragraph. Isn't the point of retry to decorate and ItemReader and ItemWriter? But the paragraph makes it sound like we decorate a Stateful Retry with and ItemReader and ItemWriter, particularly when we say, "the user providing an ItemReader and an ItemWriter" to the ItemReaderRetryCallback. Hope that helps

Wayne Lund - 14/Mar/08 09:23 AM wanted to make sure you saw my comments before closing.

Dave Syer - 14/Mar/08 10:03 AM Thanks for the comments. (By the way I would always see your comments even if you hadn't re-opened it, but thanks for doing that anyway.) 1. I opened BATCH-463 to schedule that for later. 2. Re-worded to address the "recognised" repetition. Other than that, it could be expanded on by adding some examples. It is a complex and somewhat confusing topic, so I definitely agree it deserves some careful documentation. It is also probably a side show as far as most users are concerned, so I won't do anything for now. 3. It looks OK to me. I'm not sure what you mean by "decorate" - the reader and writer are needed by the callback (hence the usage of "user provides"). In the core, this is taken care of by the factory bean, so this is really quite deep background.

Wayne Lund - 17/Mar/08 09:31 AM I just reviewed the changes. Its improved but I agree that it will need some additional documentation later. I'm fine with putting that off until later.