[#BATCH-401] aspect-oriented handling of job interruption logic

Spring Batch

aspect-oriented handling of job interruption logic

Created: 29/Feb/08 11:32 AM Updated: 04/Sep/08 03:07 AM

Component/s:

Core

Affects Version/s:

1.0.0.m5

Fix Version/s:

2.0.0.M2

Time Tracking:

Original Estimate:

0.5d

Remaining Estimate:

0.5d

Time Spent:

Not Specified

Issue Links:

Related

This issue is related to:

~~BATCH-661~~ broken job interruption logic

Description

« Hide

Interruption handling is a cross-cutting concern leading to proliferation of isTerminateOnly flags. Using an aspect that keeps a reference to JobExecution and does interruption checks in places defined by a pointcut expression seems to be a sensible approach.

All

Comments

Work Log

Change History

FishEye

Related Builds

Sort Order:

[ Permlink | « Hide ]

Robert Kasanicky added a comment - 29/Feb/08 12:27 PM - edited

prototype implementation added to samples (see GracefulShutdownTests)

[ Permlink | « Hide ]

Robert Kasanicky added a comment - 05/Mar/08 06:47 AM

Any opinions whether using the aspect for job interruption logic is the way we want to go and how it fits into the release schedule?

[ Permlink | « Hide ]

Robert Kasanicky added a comment - 18/Mar/08 09:16 AM

interrupt aspect moved to sandbox

[ Permlink | « Hide ]

Robert Kasanicky added a comment - 28/Apr/08 05:44 AM

Moving to 2.0 - it doesn't make much sense to use both declarative and programmatic interrupt checking and the current implementation seems to work fine.

[ Permlink | « Hide ]

Robert Kasanicky added a comment - 04/Sep/08 03:07 AM

The agreed approach is to check a value in the database that signals interruption, so using aspects no longer makes sense.