[#BATCH-141] Rename top-level package in infrastructure

Spring Batch

Rename top-level package in infrastructure

Created: 26/Sep/07 02:01 AM Updated: 28/Feb/08 11:25 AM

Component/s:

Infrastructure

Affects Version/s:

1.0-m1

Fix Version/s:

1.0.0.m5

Security Level:

Public (Public Issues)

Time Tracking:

Not Specified

Description

« Hide

Rename top-level package in infrastructure. The consensus seems to be org.springframework.common.* or org.springframework.foundation.*. (The common package would need to be renamed in the former case).

All

Comments

Work Log

Change History

FishEye

Builds

Sort Order:

[ Permlink | « Hide ]

Lucas Ward added a comment - 26/Sep/07 10:47 AM

Would all of the infrastructure be renamed to one of these? I think something like common.repeat or foundation.repeat makes sense, however, I'm not sure if it makes as much sense for the input and output sources, and things like Restartable, etc. Those still seem very specific to batch, or at a minimum, without batch, they would seem inconsistent with other packages within spring. For example, wouldn't it confuse people to have a SqlCursorInputSource in springframework.common? One could also wonder why a jdbc input source wouldn't be in the com.springframework.jdbc package somewhere, if it wasn't under some type of batch package.

[ Permlink | « Hide ]

Dave Syer added a comment - 03/Oct/07 09:37 AM

Restart* is the most batch-specific domain name. It would cause the most problems with renaming a package - some classes might need to be refactored as well.

[ Permlink | « Hide ]

Douglas C. Kaminsky added a comment - 11/Dec/07 10:36 AM

Why is this set for 1.1? This should be handled pre-1.0 in my opinion. Once you release 1.0 you're in a sense offering a guarantee that the package structure is somewhat stable - changing the package structure post release is going to cause a lot of problems for users.

[ Permlink | « Hide ]

Bertrand Fovez added a comment - 27/Dec/07 11:01 AM

I deeply agree with Douglas. Postponing this operation is the best way to make it quite tough, if not impossible. If you planed to rename a package - especially the top-level one, now is obviously the most appropriate time.

[ Permlink | « Hide ]

Dave Syer added a comment - 28/Feb/08 11:25 AM

We decided the batch infrastructure was batch-flavoured enough and low level enough that others would be OK to depend on it (e.g. a Spring Integration extension package).